Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sig-storage containers #5

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Update sig-storage containers #5

merged 1 commit into from
Feb 6, 2024

Conversation

addyess
Copy link

@addyess addyess commented Feb 1, 2024 •
edited
Loading

Update the sig-storage containers to something more reasonable for Kubernetes 1.29

this eliminated issues like

Failed to watch *v1beta1.CSIStorageCapacity: failed to list *v1beta1.CSIStorageCapacity: the server could not find the requested resource

there are new errors like this, but they don't impede creating a PV

external-snapshotter W0201 20:40:26.490598       1 reflector.go:424] github.com/kubernetes-csi/external-snapshotter/client/v6/informers/externalversions/f
actory.go:117: failed to list *v1.VolumeSnapshotContent: the server could not find the requested resource (get volumesnapshotcontents.snapshot.storage.k8s
.io)                                                                                                                                                      
external-snapshotter E0201 20:40:26.490628       1 reflector.go:140] github.com/kubernetes-csi/external-snapshotter/client/v6/informers/externalversions/f
actory.go:117: Failed to watch *v1.VolumeSnapshotContent: failed to list *v1.VolumeSnapshotContent: the server could not find the requested resource (get 
volumesnapshotcontents.snapshot.storage.k8s.io)

berkayoz
berkayoz approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it seems like we are not causing any issues(other than volume snapshots which isn't supported already? ).

@addyess addyess merged commit bbe4b83 into rockcraft Feb 6, 2024
3 checks passed
@addyess addyess deleted the KU-274-upgrade-rawfile-localpv-to-use-csi-v-1-ap-is branch February 6, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkayoz berkayoz berkayoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @berkayoz